Make base::Value::TYPE a scoped enum.

chrome/browser/extensions/api/notifications/notifications_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/scoped_feature_list.h"
 #include "chrome/browser/apps/app_browsertest_util.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 260 matching lines @@
     scoped_refptr<extensions::NotificationsGetPermissionLevelFunction>
         notification_function(
             new extensions::NotificationsGetPermissionLevelFunction());
 
     notification_function->set_extension(empty_extension.get());
     notification_function->set_has_callback(true);
 
     std::unique_ptr<base::Value> result(utils::RunFunctionAndReturnSingleResult(
         notification_function.get(), "[]", browser(), utils::NONE));
 
-    EXPECT_EQ(base::Value::TYPE_STRING, result->GetType());
+    EXPECT_EQ(base::Value::Type::STRING, result->GetType());
     std::string permission_level;
     EXPECT_TRUE(result->GetAsString(&permission_level));
     EXPECT_EQ("granted", permission_level);
   }
 
   // Get permission level for the extension whose notifications are disabled.
   {
     scoped_refptr<extensions::NotificationsGetPermissionLevelFunction>
         notification_function(
             new extensions::NotificationsGetPermissionLevelFunction());
 
     notification_function->set_extension(empty_extension.get());
     notification_function->set_has_callback(true);
 
     message_center::NotifierId notifier_id(
         message_center::NotifierId::APPLICATION,
         empty_extension->id());
     message_center::Notifier notifier(notifier_id, base::string16(), true);
     g_browser_process->message_center()->GetNotifierSettingsProvider()->
         SetNotifierEnabled(notifier, false);
 
     std::unique_ptr<base::Value> result(utils::RunFunctionAndReturnSingleResult(
         notification_function.get(), "[]", browser(), utils::NONE));
 
-    EXPECT_EQ(base::Value::TYPE_STRING, result->GetType());
+    EXPECT_EQ(base::Value::Type::STRING, result->GetType());
     std::string permission_level;
     EXPECT_TRUE(result->GetAsString(&permission_level));
     EXPECT_EQ("denied", permission_level);
   }
 }
 
 IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestOnPermissionLevelChanged) {
   const extensions::Extension* extension =
       LoadExtensionAndWait("notifications/api/permission");
   ASSERT_TRUE(extension) << message_;
@@ skipping 199 matching lines @@
 
   ASSERT_TRUE(GetFirstAppWindow(extension->id())->IsFullscreen())
       << "Not Fullscreen";
   ASSERT_TRUE(GetFirstAppWindow(extension->id())->GetBaseWindow()->IsActive())
       << "Not Active";
 
   const message_center::NotificationList::PopupNotifications notifications =
       g_browser_process->message_center()->GetPopupNotifications();
   ASSERT_EQ(1u, notifications.size());
 }