chrome/browser/plugins/plugin_finder_unittest.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugins/plugin_finder_unittest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/plugins/plugin_finder_unittest.cc

diff --git a/chrome/browser/plugins/plugin_finder_unittest.cc b/chrome/browser/plugins/plugin_finder_unittest.cc

index 0d6a711378947453ac08483f2aaeb6d140084ca3..ffe88b5a786d8822fb1a90e3438c72d46d00de43 100644

--- a/chrome/browser/plugins/plugin_finder_unittest.cc

+++ b/chrome/browser/plugins/plugin_finder_unittest.cc

@@ -17,7 +17,7 @@ TEST(PluginFinderTest, JsonSyntax) {

ASSERT_TRUE(plugin_list.get());

std::unique_ptr<base::Value> version;

ASSERT_TRUE(plugin_list->Remove("x-version", &version));

- EXPECT_EQ(base::Value::TYPE_INTEGER, version->GetType());

+ EXPECT_EQ(base::Value::Type::INTEGER, version->GetType());

for (base::DictionaryValue::Iterator plugin_it(*plugin_list);

!plugin_it.IsAtEnd(); plugin_it.Advance()) {