extensions/browser/extension_function.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_function.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/extension_function.cc

diff --git a/extensions/browser/extension_function.cc b/extensions/browser/extension_function.cc

index 4e56265ab213fb899f4fd1884082536eeda2afa9..c9a76ac5a8361b5e4c50501406d41b37dd27669e 100644

--- a/extensions/browser/extension_function.cc

+++ b/extensions/browser/extension_function.cc

@@ -422,7 +422,7 @@ bool ExtensionFunction::ShouldSkipQuotaLimiting() const {

bool ExtensionFunction::HasOptionalArgument(size_t index) {

base::Value* value;

- return args_->Get(index, &value) && !value->IsType(base::Value::TYPE_NULL);

+ return args_->Get(index, &value) && !value->IsType(base::Value::Type::NONE);

}

void ExtensionFunction::SendResponseImpl(bool success) {