Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: components/prefs/pref_service.h

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/prefs/pref_registry.cc ('k') | components/prefs/pref_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/prefs/pref_service.h
diff --git a/components/prefs/pref_service.h b/components/prefs/pref_service.h
index 82de7c4b79ed8852860421d95a94d3d6125999ff..d26e118d8912a90d053b9d09ca467e9fda4547f1 100644
--- a/components/prefs/pref_service.h
+++ b/components/prefs/pref_service.h
@@ -222,7 +222,7 @@ class COMPONENTS_PREFS_EXPORT PrefService : public base::NonThreadSafe {
// Int64 helper methods that actually store the given value as a string.
// Note that if obtaining the named value via GetDictionary or GetList, the
- // Value type will be TYPE_STRING.
+ // Value type will be Type::STRING.
void SetInt64(const std::string& path, int64_t value);
int64_t GetInt64(const std::string& path) const;
@@ -365,7 +365,7 @@ class COMPONENTS_PREFS_EXPORT PrefService : public base::NonThreadSafe {
// This will create a dictionary or list if one does not exist in the user
// pref store. This method returns NULL only if you're requesting an
// unregistered pref or a non-dict/non-list pref.
- // |type| may only be Values::TYPE_DICTIONARY or Values::TYPE_LIST and
+ // |type| may only be Values::Type::DICTIONARY or Values::Type::LIST and
// |path| must point to a registered preference of type |type|.
// Ownership of the returned value remains at the user pref store.
base::Value* GetMutableUserPref(const std::string& path,
« no previous file with comments | « components/prefs/pref_registry.cc ('k') | components/prefs/pref_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698