google_apis/gaia/gaia_oauth_client.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gaia/gaia_oauth_client.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gaia/gaia_oauth_client.cc

diff --git a/google_apis/gaia/gaia_oauth_client.cc b/google_apis/gaia/gaia_oauth_client.cc

index 5fe761055c76de25703a82d160bf7589b1872071..ed344082fe848037b7781ca7ad5db6441e6c6f66 100644

--- a/google_apis/gaia/gaia_oauth_client.cc

+++ b/google_apis/gaia/gaia_oauth_client.cc

@@ -271,7 +271,7 @@ void GaiaOAuthClient::Core::HandleResponse(

source->GetResponseAsString(&data);

std::unique_ptr<base::Value> message_value = base::JSONReader::Read(data);

if (message_value.get() &&

- message_value->IsType(base::Value::TYPE_DICTIONARY)) {

+ message_value->IsType(base::Value::Type::DICTIONARY)) {

response_dict.reset(

static_cast<base::DictionaryValue*>(message_value.release()));

}