Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: chrome/browser/devtools/devtools_protocol.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_protocol.cc
diff --git a/chrome/browser/devtools/devtools_protocol.cc b/chrome/browser/devtools/devtools_protocol.cc
index 34bc3b6ebbaa1fb942664d348186eeffeac1f42b..a22811053180c073bdcfd1f65072d176f448765c 100644
--- a/chrome/browser/devtools/devtools_protocol.cc
+++ b/chrome/browser/devtools/devtools_protocol.cc
@@ -93,7 +93,7 @@ bool DevToolsProtocol::ParseNotification(
std::string* method,
std::unique_ptr<base::DictionaryValue>* params) {
std::unique_ptr<base::Value> value = base::JSONReader::Read(json);
- if (!value || !value->IsType(base::Value::TYPE_DICTIONARY))
+ if (!value || !value->IsType(base::Value::Type::DICTIONARY))
return false;
std::unique_ptr<base::DictionaryValue> dict(
@@ -104,7 +104,7 @@ bool DevToolsProtocol::ParseNotification(
std::unique_ptr<base::Value> params_value;
dict->Remove(kParamsParam, &params_value);
- if (params_value && params_value->IsType(base::Value::TYPE_DICTIONARY))
+ if (params_value && params_value->IsType(base::Value::Type::DICTIONARY))
params->reset(static_cast<base::DictionaryValue*>(params_value.release()));
return true;
@@ -115,7 +115,7 @@ bool DevToolsProtocol::ParseResponse(const std::string& json,
int* command_id,
int* error_code) {
std::unique_ptr<base::Value> value = base::JSONReader::Read(json);
- if (!value || !value->IsType(base::Value::TYPE_DICTIONARY))
+ if (!value || !value->IsType(base::Value::Type::DICTIONARY))
return false;
std::unique_ptr<base::DictionaryValue> dict(
« no previous file with comments | « chrome/browser/devtools/chrome_devtools_manager_delegate.cc ('k') | chrome/browser/devtools/devtools_ui_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698