components/tracing/browser/trace_config_file.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/browser/trace_config_file.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/tracing/browser/trace_config_file.cc

diff --git a/components/tracing/browser/trace_config_file.cc b/components/tracing/browser/trace_config_file.cc

index 62220d6e678237e637b48dba1c0c3347daa2becc..97f8a16810a8ad4e7b33416507acbffde1693d78 100644

--- a/components/tracing/browser/trace_config_file.cc

+++ b/components/tracing/browser/trace_config_file.cc

@@ -98,7 +98,7 @@ TraceConfigFile::~TraceConfigFile() {

bool TraceConfigFile::ParseTraceConfigFileContent(const std::string& content) {

std::unique_ptr<base::Value> value(base::JSONReader::Read(content));

- if (!value || !value->IsType(base::Value::TYPE_DICTIONARY))

+ if (!value || !value->IsType(base::Value::Type::DICTIONARY))

return false;

std::unique_ptr<base::DictionaryValue> dict(