Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: components/bookmarks/browser/bookmark_codec_unittest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_codec_unittest.cc
diff --git a/components/bookmarks/browser/bookmark_codec_unittest.cc b/components/bookmarks/browser/bookmark_codec_unittest.cc
index edac5fe314f8d50f233862f531481496facb6130..a9d8523658af4b1be46f21c10d379bb6aecca74d 100644
--- a/components/bookmarks/browser/bookmark_codec_unittest.cc
+++ b/components/bookmarks/browser/bookmark_codec_unittest.cc
@@ -114,33 +114,33 @@ class BookmarkCodecTest : public testing::Test {
void GetBookmarksBarChildValue(base::Value* value,
size_t index,
base::DictionaryValue** result_value) {
- ASSERT_EQ(base::Value::TYPE_DICTIONARY, value->GetType());
+ ASSERT_EQ(base::Value::Type::DICTIONARY, value->GetType());
base::DictionaryValue* d_value = nullptr;
value->GetAsDictionary(&d_value);
base::Value* roots;
ASSERT_TRUE(d_value->Get(BookmarkCodec::kRootsKey, &roots));
- ASSERT_EQ(base::Value::TYPE_DICTIONARY, roots->GetType());
+ ASSERT_EQ(base::Value::Type::DICTIONARY, roots->GetType());
base::DictionaryValue* roots_d_value = nullptr;
roots->GetAsDictionary(&roots_d_value);
base::Value* bb_value;
ASSERT_TRUE(
roots_d_value->Get(BookmarkCodec::kRootFolderNameKey, &bb_value));
- ASSERT_EQ(base::Value::TYPE_DICTIONARY, bb_value->GetType());
+ ASSERT_EQ(base::Value::Type::DICTIONARY, bb_value->GetType());
base::DictionaryValue* bb_d_value = nullptr;
bb_value->GetAsDictionary(&bb_d_value);
base::Value* bb_children_value;
ASSERT_TRUE(
bb_d_value->Get(BookmarkCodec::kChildrenKey, &bb_children_value));
- ASSERT_EQ(base::Value::TYPE_LIST, bb_children_value->GetType());
+ ASSERT_EQ(base::Value::Type::LIST, bb_children_value->GetType());
base::ListValue* bb_children_l_value = nullptr;
bb_children_value->GetAsList(&bb_children_l_value);
base::Value* child_value;
ASSERT_TRUE(bb_children_l_value->Get(index, &child_value));
- ASSERT_EQ(base::Value::TYPE_DICTIONARY, child_value->GetType());
+ ASSERT_EQ(base::Value::Type::DICTIONARY, child_value->GetType());
child_value->GetAsDictionary(result_value);
}

Powered by Google App Engine
This is Rietveld 408576698