Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Unified Diff: chromeos/dbus/shill_ipconfig_client.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/shill_client_helper.cc ('k') | chromeos/geolocation/simple_geolocation_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/shill_ipconfig_client.cc
diff --git a/chromeos/dbus/shill_ipconfig_client.cc b/chromeos/dbus/shill_ipconfig_client.cc
index 778e30666d980d75df7c049f608b17b516028adc..84c1e1a11b18ff8ff566b4943ce3e4c1832817b4 100644
--- a/chromeos/dbus/shill_ipconfig_client.cc
+++ b/chromeos/dbus/shill_ipconfig_client.cc
@@ -116,7 +116,7 @@ void ShillIPConfigClientImpl::SetProperty(
writer.AppendString(name);
// IPConfig supports writing basic type and string array properties.
switch (value.GetType()) {
- case base::Value::TYPE_LIST: {
+ case base::Value::Type::LIST: {
const base::ListValue* list_value = NULL;
value.GetAsList(&list_value);
dbus::MessageWriter variant_writer(NULL);
@@ -126,7 +126,7 @@ void ShillIPConfigClientImpl::SetProperty(
for (base::ListValue::const_iterator it = list_value->begin();
it != list_value->end();
++it) {
- DLOG_IF(ERROR, (*it)->GetType() != base::Value::TYPE_STRING)
+ DLOG_IF(ERROR, (*it)->GetType() != base::Value::Type::STRING)
<< "Unexpected type " << (*it)->GetType();
std::string str;
(*it)->GetAsString(&str);
@@ -135,10 +135,10 @@ void ShillIPConfigClientImpl::SetProperty(
variant_writer.CloseContainer(&array_writer);
writer.CloseContainer(&variant_writer);
}
- case base::Value::TYPE_BOOLEAN:
- case base::Value::TYPE_INTEGER:
- case base::Value::TYPE_DOUBLE:
- case base::Value::TYPE_STRING:
+ case base::Value::Type::BOOLEAN:
+ case base::Value::Type::INTEGER:
+ case base::Value::Type::DOUBLE:
+ case base::Value::Type::STRING:
dbus::AppendBasicTypeValueDataAsVariant(&writer, value);
break;
default:
« no previous file with comments | « chromeos/dbus/shill_client_helper.cc ('k') | chromeos/geolocation/simple_geolocation_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698