chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profiles/profile_statistics_aggregator.cc ('k') | chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc b/chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc

index 54319ea4b082c73e0de8c8face57ee1007a68721..8da6f1930fb8eb3b08cadf222148041b1f68de08 100644

--- a/chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc

@@ -46,7 +46,7 @@ void KeysAndDigestsToProtobuf(

for (base::DictionaryValue::Iterator iter(keys_and_digests); !iter.IsAtEnd();

iter.Advance()) {

uint32_t digest = 0;

- if (iter.value().GetType() != base::Value::TYPE_STRING ||

+ if (iter.value().GetType() != base::Value::Type::STRING ||

!iter.value().GetAsString(&digest_value) ||

!base::StringToUint(digest_value, &digest)) {

NOTREACHED();