Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: extensions/common/extension_api.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/verified_contents.cc ('k') | extensions/common/features/json_feature_provider_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/extension_api.cc
diff --git a/extensions/common/extension_api.cc b/extensions/common/extension_api.cc
index cc3c5f7d96f870290c6547bf0af372df64d01847..a32b095048041a8e9ce15f20be96b6fcd43dca5c 100644
--- a/extensions/common/extension_api.cc
+++ b/extensions/common/extension_api.cc
@@ -47,14 +47,13 @@ std::unique_ptr<base::DictionaryValue> LoadSchemaDictionary(
// Tracking down http://crbug.com/121424
char buf[128];
- base::snprintf(buf, arraysize(buf), "%s: (%d) '%s'",
- name.c_str(),
- result.get() ? result->GetType() : -1,
- error_message.c_str());
+ base::snprintf(buf, arraysize(buf), "%s: (%d) '%s'", name.c_str(),
+ result.get() ? static_cast<int>(result->GetType()) : -1,
+ error_message.c_str());
CHECK(result.get()) << error_message << " for schema " << schema;
- CHECK(result->IsType(base::Value::TYPE_DICTIONARY)) << " for schema "
- << schema;
+ CHECK(result->IsType(base::Value::Type::DICTIONARY)) << " for schema "
+ << schema;
return base::DictionaryValue::From(std::move(result));
}
« no previous file with comments | « extensions/browser/verified_contents.cc ('k') | extensions/common/features/json_feature_provider_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698