Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
diff --git a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
index 87d5f303b768ee7b528543502c2040848c737fc0..732d1d471d3fd9777b21d651ef33ec9385873ce2 100644
--- a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
+++ b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
@@ -385,7 +385,7 @@ std::unique_ptr<base::DictionaryValue> GetDictionaryFromArray(
if (!dictionary->GetWithoutPathExpansion(*name, &entry))
return std::unique_ptr<base::DictionaryValue>();
switch (entry->GetType()) {
- case base::Value::TYPE_STRING:
+ case base::Value::Type::STRING:
// Replace the present string with a list.
list = new base::ListValue;
// Ignoring return value, we already verified the entry is there.
@@ -394,7 +394,7 @@ std::unique_ptr<base::DictionaryValue> GetDictionaryFromArray(
list->AppendString(*value);
dictionary->SetWithoutPathExpansion(*name, base::WrapUnique(list));
break;
- case base::Value::TYPE_LIST: // Just append to the list.
+ case base::Value::Type::LIST: // Just append to the list.
CHECK(entry->GetAsList(&list));
list->AppendString(*value);
break;

Powered by Google App Engine
This is Rietveld 408576698