chrome/test/chromedriver/chrome/web_view_impl_unittest.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl_unittest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome/web_view_impl_unittest.cc

diff --git a/chrome/test/chromedriver/chrome/web_view_impl_unittest.cc b/chrome/test/chromedriver/chrome/web_view_impl_unittest.cc

index 7545980d0f98d5f131d8e05cc7e14e1f37af0044..d414ead99d7550626f5a2fa6e51265ef78f31227 100644

--- a/chrome/test/chromedriver/chrome/web_view_impl_unittest.cc

+++ b/chrome/test/chromedriver/chrome/web_view_impl_unittest.cc

@@ -157,7 +157,7 @@ TEST(EvaluateScriptAndGetValue, Undefined) {

Status status =

internal::EvaluateScriptAndGetValue(&client, 0, std::string(), &result);

ASSERT_EQ(kOk, status.code());

- ASSERT_TRUE(result && result->IsType(base::Value::TYPE_NULL));

+ ASSERT_TRUE(result && result->IsType(base::Value::Type::NONE));

}

TEST(EvaluateScriptAndGetValue, Ok) {