Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1906)

Unified Diff: chrome/browser/media/webrtc/webrtc_browsertest_base.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc/webrtc_browsertest_base.cc
diff --git a/chrome/browser/media/webrtc/webrtc_browsertest_base.cc b/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
index e5376dd81787c074e5f0b019cd4c5f0132490ee9..d232889106d41036fd8bd191f11b1aa6336317b1 100644
--- a/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
+++ b/chrome/browser/media/webrtc/webrtc_browsertest_base.cc
@@ -128,7 +128,7 @@ std::vector<std::string> JsonArrayToVectorOfStrings(
const std::string& json_array) {
std::unique_ptr<base::Value> value = base::JSONReader::Read(json_array);
EXPECT_TRUE(value);
- EXPECT_TRUE(value->IsType(base::Value::TYPE_LIST));
+ EXPECT_TRUE(value->IsType(base::Value::Type::LIST));
std::unique_ptr<base::ListValue> list =
base::ListValue::From(std::move(value));
std::vector<std::string> vector;
@@ -136,7 +136,7 @@ std::vector<std::string> JsonArrayToVectorOfStrings(
for (size_t i = 0; i < list->GetSize(); ++i) {
base::Value* item;
EXPECT_TRUE(list->Get(i, &item));
- EXPECT_TRUE(item->IsType(base::Value::TYPE_STRING));
+ EXPECT_TRUE(item->IsType(base::Value::Type::STRING));
std::string item_str;
EXPECT_TRUE(item->GetAsString(&item_str));
vector.push_back(std::move(item_str));
« no previous file with comments | « chrome/browser/extensions/webstore_data_fetcher.cc ('k') | chrome/browser/media/webrtc/webrtc_getmediadevices_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698