Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2553393002: Rename BINARY to REMOTING_HOST_BINARY (Closed)

Created:
4 years ago by jdoerrie
Modified:
4 years ago
Reviewers:
Wez, joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org, brettw
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename BINARY to REMOTING_HOST_BINARY The current usage of BINARY as a define identifier prevents the usage of BINARY as a constant name in a planned refactor of base::Value (http://crrev.com/2539363004). This change addresses this issue by renaming BINARY to a more descriptive REMOTING_HOST_BINARY. BUG=646113 R=wez@chromium.org CC=brettw@chromium.org Committed: https://crrev.com/bf139498e86e7f2cc5ee1e09c63e8e71ef34918c Cr-Commit-Position: refs/heads/master@{#436951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -22 lines) Patch
M remoting/host/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/it2me/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M remoting/host/predefines_win.gni View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/security_key/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/win/BUILD.gn View 5 chunks +6 lines, -5 lines 0 comments Download
M remoting/host/win/core.rc.jinja2 View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/win/version.rc.jinja2 View 2 chunks +10 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
jdoerrie
4 years ago (2016-12-07 09:21:27 UTC) #3
joedow
lgtm
4 years ago (2016-12-07 14:51:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553393002/1
4 years ago (2016-12-07 14:52:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 14:58:04 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-07 15:00:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf139498e86e7f2cc5ee1e09c63e8e71ef34918c
Cr-Commit-Position: refs/heads/master@{#436951}

Powered by Google App Engine
This is Rietveld 408576698