chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/input_ime/input_components_handler.cc ('k') | chrome/common/extensions/manifest_handlers/theme_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc

diff --git a/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc b/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc

index 735fc19a873087f4cd27d18760b7f313f23665e1..09ff1ba56fceeda35a2146a4d0aac3b7a157f18c 100644

--- a/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc

+++ b/chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc

@@ -85,7 +85,7 @@ TEST(OverrideSettingsTest, ParseManifest) {

std::string error;

std::unique_ptr<base::Value> root(json.Deserialize(NULL, &error));

ASSERT_TRUE(root);

- ASSERT_TRUE(root->IsType(base::Value::TYPE_DICTIONARY));

+ ASSERT_TRUE(root->IsType(base::Value::Type::DICTIONARY));

scoped_refptr<Extension> extension = Extension::Create(

base::FilePath(FILE_PATH_LITERAL("//nonexistent")),

Manifest::INVALID_LOCATION,

@@ -134,7 +134,7 @@ TEST(OverrideSettingsTest, ParsePrepopulatedId) {

std::string error;

std::unique_ptr<base::Value> root(json.Deserialize(NULL, &error));

ASSERT_TRUE(root);

- ASSERT_TRUE(root->IsType(base::Value::TYPE_DICTIONARY));

+ ASSERT_TRUE(root->IsType(base::Value::Type::DICTIONARY));

scoped_refptr<Extension> extension =

Extension::Create(base::FilePath(FILE_PATH_LITERAL("//nonexistent")),

Manifest::INVALID_LOCATION,

@@ -173,7 +173,7 @@ TEST(OverrideSettingsTest, ParseBrokenManifest) {

std::string error;

std::unique_ptr<base::Value> root(json.Deserialize(NULL, &error));

ASSERT_TRUE(root);

- ASSERT_TRUE(root->IsType(base::Value::TYPE_DICTIONARY));

+ ASSERT_TRUE(root->IsType(base::Value::Type::DICTIONARY));

scoped_refptr<Extension> extension = Extension::Create(

base::FilePath(FILE_PATH_LITERAL("//nonexistent")),

Manifest::INVALID_LOCATION,