Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1698)

Unified Diff: content/public/child/v8_value_converter.h

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/child/v8_value_converter.h
diff --git a/content/public/child/v8_value_converter.h b/content/public/child/v8_value_converter.h
index aeb38c9a82933cd4f05f0f7911c22a3171af510b..9afeb397bc56b2d5acbe337f5d16538d31bb0827 100644
--- a/content/public/child/v8_value_converter.h
+++ b/content/public/child/v8_value_converter.h
@@ -117,11 +117,11 @@ class CONTENT_EXPORT V8ValueConverter {
//
// Unsupported types (unless explicitly configured) are not converted, so
// this method may return NULL -- the exception is when converting arrays,
- // where unsupported types are converted to Value(TYPE_NULL).
+ // where unsupported types are converted to Value(Type::NONE).
//
// Likewise, if an object throws while converting a property it will not be
// converted, whereas if an array throws while converting an item it will be
- // converted to Value(TYPE_NULL).
+ // converted to Value(Type::NONE).
virtual std::unique_ptr<base::Value> FromV8Value(
v8::Local<v8::Value> value,
v8::Local<v8::Context> context) const = 0;
« no previous file with comments | « content/common/android/gin_java_bridge_value.cc ('k') | content/renderer/java/gin_java_bridge_value_converter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698