Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: chrome/browser/prefs/chrome_pref_service_unittest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/chrome_pref_service_unittest.cc
diff --git a/chrome/browser/prefs/chrome_pref_service_unittest.cc b/chrome/browser/prefs/chrome_pref_service_unittest.cc
index 214b8648cecb03dadad724543fb020480eed4470..31067d3efe842d5a9fa3e34375c124be09637209 100644
--- a/chrome/browser/prefs/chrome_pref_service_unittest.cc
+++ b/chrome/browser/prefs/chrome_pref_service_unittest.cc
@@ -27,7 +27,7 @@ TEST(ChromePrefServiceTest, UpdateCommandLinePrefStore) {
ASSERT_TRUE(pref);
const base::Value* value = pref->GetValue();
ASSERT_TRUE(value);
- EXPECT_EQ(base::Value::TYPE_BOOLEAN, value->GetType());
+ EXPECT_EQ(base::Value::Type::BOOLEAN, value->GetType());
bool actual_bool_value = true;
EXPECT_TRUE(value->GetAsBoolean(&actual_bool_value));
EXPECT_FALSE(actual_bool_value);
@@ -42,7 +42,7 @@ TEST(ChromePrefServiceTest, UpdateCommandLinePrefStore) {
ASSERT_TRUE(pref);
value = pref->GetValue();
ASSERT_TRUE(value);
- EXPECT_EQ(base::Value::TYPE_BOOLEAN, value->GetType());
+ EXPECT_EQ(base::Value::Type::BOOLEAN, value->GetType());
actual_bool_value = false;
EXPECT_TRUE(value->GetAsBoolean(&actual_bool_value));
EXPECT_TRUE(actual_bool_value);
« no previous file with comments | « chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc ('k') | chrome/browser/prefs/pref_service_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698