Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: components/user_prefs/tracked/pref_hash_calculator_unittest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/update_client/component_unpacker.cc ('k') | components/webcrypto/algorithms/test_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/user_prefs/tracked/pref_hash_calculator_unittest.cc
diff --git a/components/user_prefs/tracked/pref_hash_calculator_unittest.cc b/components/user_prefs/tracked/pref_hash_calculator_unittest.cc
index 1b3ecd793f5f9a453fcc0228773af0f225584fd2..4d29146ada9a9660dced34f019dd3d65e4717c31 100644
--- a/components/user_prefs/tracked/pref_hash_calculator_unittest.cc
+++ b/components/user_prefs/tracked/pref_hash_calculator_unittest.cc
@@ -111,15 +111,15 @@ TEST(PrefHashCalculatorTest, CatchHashChanges) {
list_value->AppendInteger(100);
list_value->AppendDouble(1.0);
- ASSERT_EQ(base::Value::TYPE_NULL, null_value->GetType());
- ASSERT_EQ(base::Value::TYPE_BOOLEAN, bool_value->GetType());
- ASSERT_EQ(base::Value::TYPE_INTEGER, int_value->GetType());
- ASSERT_EQ(base::Value::TYPE_DOUBLE, double_value->GetType());
- ASSERT_EQ(base::Value::TYPE_STRING, string_value->GetType());
- ASSERT_EQ(base::Value::TYPE_DICTIONARY, dict_value->GetType());
- ASSERT_EQ(base::Value::TYPE_LIST, list_value->GetType());
-
- // Test every value type independently. Intentionally omits TYPE_BINARY which
+ ASSERT_EQ(base::Value::Type::NONE, null_value->GetType());
+ ASSERT_EQ(base::Value::Type::BOOLEAN, bool_value->GetType());
+ ASSERT_EQ(base::Value::Type::INTEGER, int_value->GetType());
+ ASSERT_EQ(base::Value::Type::DOUBLE, double_value->GetType());
+ ASSERT_EQ(base::Value::Type::STRING, string_value->GetType());
+ ASSERT_EQ(base::Value::Type::DICTIONARY, dict_value->GetType());
+ ASSERT_EQ(base::Value::Type::LIST, list_value->GetType());
+
+ // Test every value type independently. Intentionally omits Type::BINARY which
// isn't even allowed in JSONWriter's input.
static const char kExpectedNullValue[] =
"82A9F3BBC7F9FF84C76B033C854E79EEB162783FA7B3E99FF9372FA8E12C44F7";
« no previous file with comments | « components/update_client/component_unpacker.cc ('k') | components/webcrypto/algorithms/test_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698