chrome/browser/extensions/alert_apitest.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/alert_apitest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/alert_apitest.cc

diff --git a/chrome/browser/extensions/alert_apitest.cc b/chrome/browser/extensions/alert_apitest.cc

index 718bc18e89b05dcfc22965a8587a2775dab1cfac..9d638b961d80b963c90ddc581c3fde2ade0847ba 100644

--- a/chrome/browser/extensions/alert_apitest.cc

+++ b/chrome/browser/extensions/alert_apitest.cc

@@ -55,7 +55,7 @@ void CheckAlertResult(const std::string& dialog_name,

size_t* call_count,

const base::Value* value) {

ASSERT_TRUE(value) << dialog_name;

- ASSERT_TRUE(value->IsType(base::Value::TYPE_NULL));

+ ASSERT_TRUE(value->IsType(base::Value::Type::NONE));

++*call_count;

}