extensions/browser/api/management/management_api.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/management/management_api.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/management/management_api.cc

diff --git a/extensions/browser/api/management/management_api.cc b/extensions/browser/api/management/management_api.cc

index fb4c4198ce9f6de6fd2ed80b2dfdc7e8df4c7539..0c9d32584a3b7d456f0e2087ee2f1b718970ece5 100644

--- a/extensions/browser/api/management/management_api.cc

+++ b/extensions/browser/api/management/management_api.cc

@@ -346,7 +346,7 @@ bool ManagementGetPermissionWarningsByManifestFunction::RunAsync() {

void ManagementGetPermissionWarningsByManifestFunction::OnParseSuccess(

std::unique_ptr<base::Value> value) {

- if (!value->IsType(base::Value::TYPE_DICTIONARY)) {

+ if (!value->IsType(base::Value::Type::DICTIONARY)) {

OnParseFailure(keys::kManifestParseError);

return;

}