Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2271)

Unified Diff: chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/policy/policy_browsertest.cc ('k') | chrome/browser/prefs/chrome_pref_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc
diff --git a/chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc b/chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc
index 972232b7060c352bedb19978eb6560c597980fcc..50547cffee6a0b62f2d3c8f7fb1f7808147d351f 100644
--- a/chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc
+++ b/chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc
@@ -37,7 +37,7 @@ class TestCommandLinePrefStore : public ChromeCommandLinePrefStore {
void VerifyProxyMode(ProxyPrefs::ProxyMode expected_mode) {
const base::Value* value = NULL;
ASSERT_TRUE(GetValue(proxy_config::prefs::kProxy, &value));
- ASSERT_EQ(base::Value::TYPE_DICTIONARY, value->GetType());
+ ASSERT_EQ(base::Value::Type::DICTIONARY, value->GetType());
ProxyConfigDictionary dict(
static_cast<const base::DictionaryValue*>(value));
ProxyPrefs::ProxyMode actual_mode;
@@ -49,7 +49,7 @@ class TestCommandLinePrefStore : public ChromeCommandLinePrefStore {
size_t cipher_count) {
const base::Value* value = NULL;
ASSERT_TRUE(GetValue(ssl_config::prefs::kCipherSuiteBlacklist, &value));
- ASSERT_EQ(base::Value::TYPE_LIST, value->GetType());
+ ASSERT_EQ(base::Value::Type::LIST, value->GetType());
const base::ListValue* list_value =
static_cast<const base::ListValue*>(value);
ASSERT_EQ(cipher_count, list_value->GetSize());
@@ -121,7 +121,7 @@ TEST(ChromeCommandLinePrefStoreTest, MultipleSwitches) {
const base::Value* value = NULL;
ASSERT_TRUE(store->GetValue(proxy_config::prefs::kProxy, &value));
- ASSERT_EQ(base::Value::TYPE_DICTIONARY, value->GetType());
+ ASSERT_EQ(base::Value::Type::DICTIONARY, value->GetType());
ProxyConfigDictionary dict(static_cast<const base::DictionaryValue*>(value));
std::string string_result;
« no previous file with comments | « chrome/browser/policy/policy_browsertest.cc ('k') | chrome/browser/prefs/chrome_pref_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698