Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_protocol.cc ('k') | chrome/browser/devtools/devtools_window.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_ui_bindings.cc
diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc
index 718fce46eb02a9df0945a07b28be400a247d4f27..5d37fc73d7094712c70d9732034ffd9e834f6bd1 100644
--- a/chrome/browser/devtools/devtools_ui_bindings.cc
+++ b/chrome/browser/devtools/devtools_ui_bindings.cc
@@ -691,7 +691,7 @@ void DevToolsUIBindings::SetWhitelistedShortcuts(const std::string& message) {
void DevToolsUIBindings::ShowCertificateViewer(const std::string& cert_chain) {
std::unique_ptr<base::Value> value =
base::JSONReader::Read(cert_chain);
- if (!value || value->GetType() != base::Value::TYPE_LIST) {
+ if (!value || value->GetType() != base::Value::Type::LIST) {
NOTREACHED();
return;
}
@@ -701,7 +701,7 @@ void DevToolsUIBindings::ShowCertificateViewer(const std::string& cert_chain) {
std::vector<std::string> decoded;
for (size_t i = 0; i < list->GetSize(); ++i) {
base::Value* item;
- if (!list->Get(i, &item) || item->GetType() != base::Value::TYPE_STRING) {
+ if (!list->Get(i, &item) || item->GetType() != base::Value::Type::STRING) {
NOTREACHED();
return;
}
« no previous file with comments | « chrome/browser/devtools/devtools_protocol.cc ('k') | chrome/browser/devtools/devtools_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698