Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2655)

Unified Diff: extensions/renderer/event_bindings.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/event_bindings.cc
diff --git a/extensions/renderer/event_bindings.cc b/extensions/renderer/event_bindings.cc
index df1de04e8912235560ff186d8f3b7173df02b307..e65d8242ff04a3190d85a34b5f3d325e4920ef93 100644
--- a/extensions/renderer/event_bindings.cc
+++ b/extensions/renderer/event_bindings.cc
@@ -264,7 +264,7 @@ void EventBindings::AttachFilteredEvent(
content::V8ValueConverter::create());
std::unique_ptr<base::Value> filter_value(converter->FromV8Value(
v8::Local<v8::Object>::Cast(args[1]), context()->v8_context()));
- if (!filter_value || !filter_value->IsType(base::Value::TYPE_DICTIONARY)) {
+ if (!filter_value || !filter_value->IsType(base::Value::Type::DICTIONARY)) {
args.GetReturnValue().Set(static_cast<int32_t>(-1));
return;
}
« no previous file with comments | « extensions/renderer/activity_log_converter_strategy_unittest.cc ('k') | extensions/renderer/send_request_natives.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698