base/test/trace_event_analyzer.cc - Issue 2539363004: Make base::Value::TYPE a scoped enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/trace_event_analyzer.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)

Patch Set: Rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/test/trace_event_analyzer.cc

diff --git a/base/test/trace_event_analyzer.cc b/base/test/trace_event_analyzer.cc

index 64436dc1444bfd6e5db0a4c8762ea3392b1b6fbd..5e0976867f2c866448973d86f821cbaa5b6fa90e 100644

--- a/base/test/trace_event_analyzer.cc

+++ b/base/test/trace_event_analyzer.cc

@@ -34,8 +34,8 @@ TraceEvent::~TraceEvent() {

TraceEvent& TraceEvent::operator=(TraceEvent&& rhs) = default;

bool TraceEvent::SetFromJSON(const base::Value* event_value) {

- if (event_value->GetType() != base::Value::TYPE_DICTIONARY) {

- LOG(ERROR) << "Value must be TYPE_DICTIONARY";

+ if (event_value->GetType() != base::Value::Type::DICTIONARY) {

+ LOG(ERROR) << "Value must be Type::DICTIONARY";

return false;

}

const base::DictionaryValue* dictionary =

« no previous file with comments | « base/json/json_writer.cc ('k') | base/test/trace_event_analyzer_unittest.cc » ('j') | no next file with comments »