Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: components/nacl/renderer/json_manifest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/renderer/json_manifest.cc
diff --git a/components/nacl/renderer/json_manifest.cc b/components/nacl/renderer/json_manifest.cc
index 8ae26037753f1d28097f43800839e7c505d05386..dda39339abd4a1be6e7673f95cafdd005cc9d5e3 100644
--- a/components/nacl/renderer/json_manifest.cc
+++ b/components/nacl/renderer/json_manifest.cc
@@ -200,7 +200,7 @@ bool IsValidUrlSpec(const base::Value& url_spec,
// URL was already verified above by IsValidDictionary to be required.
url_dict->GetWithoutPathExpansion(kUrlKey, &url);
DCHECK(url);
- if (!url->IsType(base::Value::TYPE_STRING)) {
+ if (!url->IsType(base::Value::Type::STRING)) {
std::stringstream error_stream;
error_stream << parent_key << " property '" << container_key
<< "' has non-string value '" << *url << "' for key '"
@@ -212,7 +212,7 @@ bool IsValidUrlSpec(const base::Value& url_spec,
const base::Value* opt_level = nullptr;
url_dict->GetWithoutPathExpansion(kOptLevelKey, &opt_level);
DCHECK(opt_level);
- if (!opt_level->IsType(base::Value::TYPE_INTEGER)) {
+ if (!opt_level->IsType(base::Value::Type::INTEGER)) {
std::stringstream error_stream;
error_stream << parent_key << " property '" << container_key
<< "' has non-numeric value '" << *opt_level << "' for key '"

Powered by Google App Engine
This is Rietveld 408576698