Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: components/policy/core/common/schema.h

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/policy/core/common/registry_dict.cc ('k') | components/policy/core/common/schema.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/policy/core/common/schema.h
diff --git a/components/policy/core/common/schema.h b/components/policy/core/common/schema.h
index ec7614861ef132d354bc1c93deb9d218e6e2cb71..cd0f46329eb215ffe2e61f622630a9a610415149 100644
--- a/components/policy/core/common/schema.h
+++ b/components/policy/core/common/schema.h
@@ -113,7 +113,7 @@ class POLICY_EXPORT Schema {
std::string* error,
bool* changed) const;
- // Used to iterate over the known properties of TYPE_DICTIONARY schemas.
+ // Used to iterate over the known properties of Type::DICTIONARY schemas.
class POLICY_EXPORT Iterator {
public:
Iterator(const scoped_refptr<const InternalStorage>& storage,
@@ -141,7 +141,7 @@ class POLICY_EXPORT Schema {
const internal::PropertyNode* end_;
};
- // These methods should be called only if type() == TYPE_DICTIONARY,
+ // These methods should be called only if type() == Type::DICTIONARY,
// otherwise invalid memory will be read. A CHECK is currently enforcing this.
// Returns an iterator that goes over the named properties of this schema.
@@ -172,7 +172,7 @@ class POLICY_EXPORT Schema {
SchemaList GetMatchingProperties(const std::string& key) const;
// Returns the Schema for items of an array.
- // This method should be called only if type() == TYPE_LIST,
+ // This method should be called only if type() == Type::LIST,
// otherwise invalid memory will be read. A CHECK is currently enforcing this.
Schema GetItems() const;
« no previous file with comments | « components/policy/core/common/registry_dict.cc ('k') | components/policy/core/common/schema.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698