Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: device/geolocation/network_location_request.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dbus/values_util.cc ('k') | extensions/browser/api/cast_channel/cast_channel_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/geolocation/network_location_request.cc
diff --git a/device/geolocation/network_location_request.cc b/device/geolocation/network_location_request.cc
index 00a142bb734e95180135b2b08b4ae216f71e1c9f..191f7a561baf8bc960a7e39fa3150f702961807e 100644
--- a/device/geolocation/network_location_request.cc
+++ b/device/geolocation/network_location_request.cc
@@ -367,7 +367,7 @@ bool ParseServerResponse(const std::string& response_body,
return false;
}
- if (!response_value->IsType(base::Value::TYPE_DICTIONARY)) {
+ if (!response_value->IsType(base::Value::Type::DICTIONARY)) {
VLOG(1) << "ParseServerResponse() : Unexpected response type "
<< response_value->GetType();
return false;
@@ -388,8 +388,8 @@ bool ParseServerResponse(const std::string& response_body,
}
DCHECK(location_value);
- if (!location_value->IsType(base::Value::TYPE_DICTIONARY)) {
- if (!location_value->IsType(base::Value::TYPE_NULL)) {
+ if (!location_value->IsType(base::Value::Type::DICTIONARY)) {
+ if (!location_value->IsType(base::Value::Type::NONE)) {
VLOG(1) << "ParseServerResponse() : Unexpected location type "
<< location_value->GetType();
// If the network provider was unable to provide a position fix, it should
« no previous file with comments | « dbus/values_util.cc ('k') | extensions/browser/api/cast_channel/cast_channel_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698