Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: content/browser/android/java/gin_java_method_invocation_helper.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/java/gin_java_method_invocation_helper.cc
diff --git a/content/browser/android/java/gin_java_method_invocation_helper.cc b/content/browser/android/java/gin_java_method_invocation_helper.cc
index a2e73ef2d695803b7551dd98a808f574d52d0652..e6b90a7e03fdd691d85d6f7e3aea5d94b0e4ee06 100644
--- a/content/browser/android/java/gin_java_method_invocation_helper.cc
+++ b/content/browser/android/java/gin_java_method_invocation_helper.cc
@@ -52,15 +52,15 @@ void GinJavaMethodInvocationHelper::Init(DispatcherDelegate* dispatcher) {
void GinJavaMethodInvocationHelper::BuildObjectRefsFromListValue(
DispatcherDelegate* dispatcher,
const base::Value& list_value) {
- DCHECK(list_value.IsType(base::Value::TYPE_LIST));
+ DCHECK(list_value.IsType(base::Value::Type::LIST));
const base::ListValue* list;
list_value.GetAsList(&list);
for (const auto& entry : *list) {
if (AppendObjectRef(dispatcher, *entry))
continue;
- if (entry->IsType(base::Value::TYPE_LIST)) {
+ if (entry->IsType(base::Value::Type::LIST)) {
BuildObjectRefsFromListValue(dispatcher, *entry);
- } else if (entry->IsType(base::Value::TYPE_DICTIONARY)) {
+ } else if (entry->IsType(base::Value::Type::DICTIONARY)) {
BuildObjectRefsFromDictionaryValue(dispatcher, *entry);
}
}
@@ -69,7 +69,7 @@ void GinJavaMethodInvocationHelper::BuildObjectRefsFromListValue(
void GinJavaMethodInvocationHelper::BuildObjectRefsFromDictionaryValue(
DispatcherDelegate* dispatcher,
const base::Value& dict_value) {
- DCHECK(dict_value.IsType(base::Value::TYPE_DICTIONARY));
+ DCHECK(dict_value.IsType(base::Value::Type::DICTIONARY));
const base::DictionaryValue* dict;
dict_value.GetAsDictionary(&dict);
for (base::DictionaryValue::Iterator iter(*dict);
@@ -77,9 +77,9 @@ void GinJavaMethodInvocationHelper::BuildObjectRefsFromDictionaryValue(
iter.Advance()) {
if (AppendObjectRef(dispatcher, iter.value()))
continue;
- if (iter.value().IsType(base::Value::TYPE_LIST)) {
+ if (iter.value().IsType(base::Value::Type::LIST)) {
BuildObjectRefsFromListValue(dispatcher, iter.value());
- } else if (iter.value().IsType(base::Value::TYPE_DICTIONARY)) {
+ } else if (iter.value().IsType(base::Value::Type::DICTIONARY)) {
BuildObjectRefsFromDictionaryValue(dispatcher, iter.value());
}
}

Powered by Google App Engine
This is Rietveld 408576698