Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6880)

Unified Diff: chrome/test/chromedriver/capabilities.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/capabilities.cc
diff --git a/chrome/test/chromedriver/capabilities.cc b/chrome/test/chromedriver/capabilities.cc
index 60ad11cd71f64c961a035e5b0798d5feee7e39c7..28d42ab5a9a46a4bb7717a9895f7255f3681afe1 100644
--- a/chrome/test/chromedriver/capabilities.cc
+++ b/chrome/test/chromedriver/capabilities.cc
@@ -257,7 +257,7 @@ Status ParseProxy(const base::Value& option, Capabilities* capabilities) {
std::string proxy_servers;
for (size_t i = 0; i < arraysize(proxy_servers_options); ++i) {
if (!proxy_dict->Get(proxy_servers_options[i][0], &option_value) ||
- option_value->IsType(base::Value::TYPE_NULL)) {
+ option_value->IsType(base::Value::Type::NONE)) {
continue;
}
std::string value;
@@ -277,7 +277,7 @@ Status ParseProxy(const base::Value& option, Capabilities* capabilities) {
std::string proxy_bypass_list;
if (proxy_dict->Get("noProxy", &option_value) &&
- !option_value->IsType(base::Value::TYPE_NULL)) {
+ !option_value->IsType(base::Value::Type::NONE)) {
if (!option_value->GetAsString(&proxy_bypass_list))
return Status(kUnknownError, "'noProxy' must be a string");
}
« no previous file with comments | « chrome/test/base/extension_js_browser_test.cc ('k') | chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698