Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: headless/public/domains/types_unittest.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/json/json_reader.h" 5 #include "base/json/json_reader.h"
6 #include "base/json/json_string_value_serializer.h" 6 #include "base/json/json_string_value_serializer.h"
7 #include "headless/public/devtools/domains/accessibility.h" 7 #include "headless/public/devtools/domains/accessibility.h"
8 #include "headless/public/devtools/domains/dom.h" 8 #include "headless/public/devtools/domains/dom.h"
9 #include "headless/public/devtools/domains/memory.h" 9 #include "headless/public/devtools/domains/memory.h"
10 #include "headless/public/devtools/domains/page.h" 10 #include "headless/public/devtools/domains/page.h"
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 } 197 }
198 198
199 TEST(TypesTest, AnyProperty) { 199 TEST(TypesTest, AnyProperty) {
200 std::unique_ptr<base::Value> value(new base::FundamentalValue(123)); 200 std::unique_ptr<base::Value> value(new base::FundamentalValue(123));
201 std::unique_ptr<accessibility::AXValue> object( 201 std::unique_ptr<accessibility::AXValue> object(
202 accessibility::AXValue::Builder() 202 accessibility::AXValue::Builder()
203 .SetType(accessibility::AXValueType::INTEGER) 203 .SetType(accessibility::AXValueType::INTEGER)
204 .SetValue(std::move(value)) 204 .SetValue(std::move(value))
205 .Build()); 205 .Build());
206 EXPECT_TRUE(object); 206 EXPECT_TRUE(object);
207 EXPECT_EQ(base::Value::TYPE_INTEGER, object->GetValue()->GetType()); 207 EXPECT_EQ(base::Value::Type::INTEGER, object->GetValue()->GetType());
208 208
209 std::unique_ptr<accessibility::AXValue> clone(object->Clone()); 209 std::unique_ptr<accessibility::AXValue> clone(object->Clone());
210 EXPECT_TRUE(clone); 210 EXPECT_TRUE(clone);
211 EXPECT_EQ(base::Value::TYPE_INTEGER, clone->GetValue()->GetType()); 211 EXPECT_EQ(base::Value::Type::INTEGER, clone->GetValue()->GetType());
212 212
213 int clone_value; 213 int clone_value;
214 EXPECT_TRUE(clone->GetValue()->GetAsInteger(&clone_value)); 214 EXPECT_TRUE(clone->GetValue()->GetAsInteger(&clone_value));
215 EXPECT_EQ(123, clone_value); 215 EXPECT_EQ(123, clone_value);
216 } 216 }
217 217
218 TEST(TypesTest, ComplexObjectClone) { 218 TEST(TypesTest, ComplexObjectClone) {
219 std::vector<std::unique_ptr<dom::Node>> child_nodes; 219 std::vector<std::unique_ptr<dom::Node>> child_nodes;
220 child_nodes.emplace_back(dom::Node::Builder() 220 child_nodes.emplace_back(dom::Node::Builder()
221 .SetNodeId(1) 221 .SetNodeId(1)
(...skipping 12 matching lines...) Expand all
234 ASSERT_NE(nullptr, clone); 234 ASSERT_NE(nullptr, clone);
235 235
236 std::string orig; 236 std::string orig;
237 JSONStringValueSerializer(&orig).Serialize(*params->Serialize()); 237 JSONStringValueSerializer(&orig).Serialize(*params->Serialize());
238 std::string clone_value; 238 std::string clone_value;
239 JSONStringValueSerializer(&clone_value).Serialize(*clone->Serialize()); 239 JSONStringValueSerializer(&clone_value).Serialize(*clone->Serialize());
240 EXPECT_EQ(orig, clone_value); 240 EXPECT_EQ(orig, clone_value);
241 } 241 }
242 242
243 } // namespace headless 243 } // namespace headless
OLDNEW
« no previous file with comments | « headless/lib/browser/devtools_api/domain_cc.template ('k') | ios/chrome/browser/find_in_page/js_findinpage_manager.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698