Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: ios/web/webui/mojo_facade.mm

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/web_state/ui/web_view_js_utils_unittest.mm ('k') | ipc/ipc_message_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/webui/mojo_facade.mm
diff --git a/ios/web/webui/mojo_facade.mm b/ios/web/webui/mojo_facade.mm
index a0a9ff5a6e63b627137c194c99cec97273aac490..bdea3d34c6bd874cbd798767b5df63b6eb14742e 100644
--- a/ios/web/webui/mojo_facade.mm
+++ b/ios/web/webui/mojo_facade.mm
@@ -25,7 +25,7 @@ namespace web {
namespace {
-// Wraps an integer into |base::Value| as |TYPE_INTEGER|.
+// Wraps an integer into |base::Value| as |Type::INTEGER|.
template <typename IntegerT>
std::unique_ptr<base::Value> ValueFromInteger(IntegerT handle) {
return std::unique_ptr<base::Value>(
@@ -136,14 +136,14 @@ std::unique_ptr<base::Value> MojoFacade::HandleCoreCreateMessagePipe(
const base::Value* options_as_value = nullptr;
CHECK(args->Get("optionsDict", &options_as_value));
- if (options_as_value->IsType(base::Value::TYPE_DICTIONARY)) {
+ if (options_as_value->IsType(base::Value::Type::DICTIONARY)) {
// There are no options defined for CreateMessagePipe yet.
const base::DictionaryValue* options_as_dict;
options_as_value->GetAsDictionary(&options_as_dict);
CHECK(options_as_dict->empty());
}
- CHECK(options_as_value->IsType(base::Value::TYPE_NULL));
+ CHECK(options_as_value->IsType(base::Value::Type::NONE));
mojo::MessagePipe message_pipe;
std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue);
« no previous file with comments | « ios/web/web_state/ui/web_view_js_utils_unittest.mm ('k') | ipc/ipc_message_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698