Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: extensions/common/manifest_handlers/background_info.cc

Issue 2539363004: Make base::Value::TYPE a scoped enum. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/manifest_handlers/background_info.cc
diff --git a/extensions/common/manifest_handlers/background_info.cc b/extensions/common/manifest_handlers/background_info.cc
index 7f39b0090d5fbc823f307d23898cd3a734c105eb..3cd0bc4021df0803ce3e661092d7f821dea20078 100644
--- a/extensions/common/manifest_handlers/background_info.cc
+++ b/extensions/common/manifest_handlers/background_info.cc
@@ -126,7 +126,7 @@ bool BackgroundInfo::LoadBackgroundScripts(const Extension* extension,
return true;
CHECK(background_scripts_value);
- if (background_scripts_value->GetType() != base::Value::TYPE_LIST) {
+ if (background_scripts_value->GetType() != base::Value::Type::LIST) {
*error = ASCIIToUTF16(errors::kInvalidBackgroundScripts);
return false;
}
@@ -233,7 +233,7 @@ bool BackgroundInfo::LoadAllowJSAccess(const Extension* extension,
&allow_js_access))
return true;
- if (!allow_js_access->IsType(base::Value::TYPE_BOOLEAN) ||
+ if (!allow_js_access->IsType(base::Value::Type::BOOLEAN) ||
!allow_js_access->GetAsBoolean(&allow_js_access_)) {
*error = ASCIIToUTF16(errors::kInvalidBackgroundAllowJsAccess);
return false;
« no previous file with comments | « extensions/common/file_util_unittest.cc ('k') | extensions/renderer/activity_log_converter_strategy_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698