Remove OwnPtr from Blink.

Remove OwnPtr from Blink.

This huge patch basically consists of the following changes:
  (1) OwnPtr/PassOwnPtr getting renamed to std::unique_ptr;
  (2) adoptPtr getting renamed to wrapUnique;
  (3) adjustments in #include files; and
  (4) occasional addition of .get() calls due to missing operator==()
      comparison of std::unique_ptr<T> and T*.

BUG=582354
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
R=haraken@chromium.org, tkent@chromium.org, tzik@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/f5f08765522594f41a1c032754e4fbc30e90c134

[Yuta Kitamura, 2016-06-09 07:51:36]

Description was changed from

==========
Kill OwnPtr! (aka Rietveld stress test)
==========

to

==========
Kill OwnPtr! (aka Rietveld stress test)
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Yuta Kitamura, 2016-06-09 08:04:10]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-09 08:04:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2050123002/1

[commit-bot: I haz the power, 2016-06-09 08:12:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 08:12:30]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yuta Kitamura, 2016-06-09 08:19:52]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-09 08:20:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2050123002/10001

[commit-bot: I haz the power, 2016-06-09 08:57:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 08:57:59]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Yuta Kitamura, 2016-06-09 09:31:50]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-09 09:32:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2050123002/20001

[commit-bot: I haz the power, 2016-06-09 09:43:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 09:43:56]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yuta Kitamura, 2016-06-09 09:51:57]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-09 09:52:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2050123002/30001

[commit-bot: I haz the power, 2016-06-09 15:44:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 15:44:40]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Yuta Kitamura, 2016-06-13 06:25:41]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 06:25:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2050123002/40001

[Yuta Kitamura, 2016-06-13 07:53:19]

Description was changed from

==========
Kill OwnPtr! (aka Rietveld stress test)
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove OwnPtr from Blink.

This huge patch basically consists of the following changes:
  (1) OwnPtr/PassOwnPtr getting renamed to std::unique_ptr;
  (2) adoptPtr getting renamed to wrapUnique;
  (3) adjustments in #include files; and
  (4) occasional addition of .get() calls due to missing operator==()
      comparison of std::unique_ptr<T> and T*.

BUG=582354
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Yuta Kitamura, 2016-06-13 07:53:23]

yutak@chromium.org changed reviewers:
+ haraken@chromium.org, tkent@chromium.org, tzik@chromium.org

[commit-bot: I haz the power, 2016-06-13 08:11:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 08:11:57]

Dry run: Exceeded global retry quota

[Yuta Kitamura, 2016-06-13 08:13:45]

Note: It takes a long time to load this Rietveld issue
because it contains ~1500 changed files; wait for 30 seconds
or so to get it loaded.

I will send a PSA to blink-dev and chromium-dev that I will
going to close the tree when I land this to avoid conflicts
and unexpected regressions. Landing is scheduled on June
19th (Sunday).

I'm also planning to land this with --bypass-hooks specified
because it does not make sense to fix all the existing errors
with this patch. I briefly skimmed through the lint results
and confirmed they did not contain the indication of newly
introduced errors.

All reviewers: I know it's pretty hard to go through
all the changes; I'd like to ask you to pick some files
randomly and do sanity checks on them. If you happen to see
a bad pattern, please let me know.

I can send you a diff file upon request so you can review
this locally, to avoid the slowness of Rietveld UI.

Thanks!

[haraken, 2016-06-13 08:49:22]

I just looked at randomly picked-up 50 files. LGTM to land after announcing to
blink-dev@.

[tkent, 2016-06-14 02:23:47]

https://codereview.chromium.org/2050123002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h
(right):

https://codereview.chromium.org/2050123002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h:141: static
std::unique_ptr<T> adopt(std::unique_ptr<T>& x) { return
wrapUnique(x.release()); }
Should wrapUnique and .release() here be std:move()?

https://codereview.chromium.org/2050123002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp (right):

https://codereview.chromium.org/2050123002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp:45: #include
<memory>
You don't need to include <memory> if the primary header, DOMWrapperWorld.h
includes <memory>.

https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
> However, any includes present in the related header do not need to
> be included again in the related cc (i.e., foo.cc can rely on foo.h's
> includes).

https://codereview.chromium.org/2050123002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/ExecutionContextTask.h (right):

https://codereview.chromium.org/2050123002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/ExecutionContextTask.h:107: return
internal::createCallClosureTask(WTF::bind(function,
std::forward<P>(parameters)...));
Is this change necessary?

[Yuta Kitamura, 2016-06-14 04:44:44]

https://codereview.chromium.org/2050123002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h
(right):

https://codereview.chromium.org/2050123002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h:141: static
std::unique_ptr<T> adopt(std::unique_ptr<T>& x) { return
wrapUnique(x.release()); }
On 2016/06/14 02:23:47, tkent wrote:
> Should wrapUnique and .release() here be std:move()?

Yeah, that's weird. I'm going to fix this in the
next merge cycle.

https://codereview.chromium.org/2050123002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp (right):

https://codereview.chromium.org/2050123002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp:45: #include
<memory>
On 2016/06/14 02:23:47, tkent wrote:
> You don't need to include <memory> if the primary header, DOMWrapperWorld.h
> includes <memory>.
> 
> https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
> > However, any includes present in the related header do not need to
> > be included again in the related cc (i.e., foo.cc can rely on foo.h's
> > includes).

I know, but the automatic #include handling was already
too complex and decided to go with the current manner
(#include whatever used in the file). I assume that's
allowed and harmless.

The complication around #include was:
* Various #include forms (e.g. some include the primary
  header first, some not)
* Detection of primary header (e.g. Xxxx.h is the primary
  header for XxxxMac.cpp; we even have files named like
  chromium_style.cc)
* #include guarded with #if
* etc.

https://codereview.chromium.org/2050123002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/ExecutionContextTask.h (right):

https://codereview.chromium.org/2050123002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/ExecutionContextTask.h:107: return
internal::createCallClosureTask(WTF::bind(function,
std::forward<P>(parameters)...));
On 2016/06/14 02:23:47, tkent wrote:
> Is this change necessary?

Yes, because this becomes ambiguous with std::bind due to
ADL (argument dependent lookup).

[Yuta Kitamura, 2016-06-14 06:27:00]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 06:27:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2050123002/50001

[commit-bot: I haz the power, 2016-06-14 09:55:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 09:55:52]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-06-15 03:56:19]

lgtm

[tzik, 2016-06-15 12:49:39]

https://codereview.chromium.org/2050123002/diff/50001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/ExecutionContextTask.h (right):

https://codereview.chromium.org/2050123002/diff/50001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/ExecutionContextTask.h:107: return
internal::createCallClosureTask(WTF::bind(function,
std::forward<P>(parameters)...));
Just a comment: Without `WTF::`, `bind` is ambiguous to std::bind, which is
brought by ADL, right?

https://codereview.chromium.org/2050123002/diff/50001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.h
(right):

https://codereview.chromium.org/2050123002/diff/50001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.h:74: #endif
// XMLHttpRequestUpload_h
----✂----
Just a progress report. I looked this file and above. Looks good so far.

[Yuta Kitamura, 2016-06-16 09:12:08]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-16 09:12:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2050123002/60001

[commit-bot: I haz the power, 2016-06-16 12:37:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 12:37:18]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Yuta Kitamura, 2016-06-17 08:07:36]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 08:08:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2050123002/70001

[commit-bot: I haz the power, 2016-06-17 10:39:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 10:39:11]

Dry run: This issue passed the CQ dry run.

[Yuta Kitamura, 2016-06-17 12:11:16]

https://codereview.chromium.org/2050123002/diff/50001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/ExecutionContextTask.h (right):

https://codereview.chromium.org/2050123002/diff/50001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/ExecutionContextTask.h:107: return
internal::createCallClosureTask(WTF::bind(function,
std::forward<P>(parameters)...));
On 2016/06/15 12:49:38, tzik wrote:
> Just a comment: Without `WTF::`, `bind` is ambiguous to std::bind, which is
> brought by ADL, right?

Yes.

[tzik, 2016-06-17 22:23:42]

I finally look through them all. LGTM.

[Yuta Kitamura, 2016-06-19 00:18:57]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-19 00:19:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2050123002/80001

[Yuta Kitamura, 2016-06-19 01:00:52]

On 2016/06/17 22:23:42, tzik wrote:
> I finally look through them all. LGTM.

Thanks a lot!

[commit-bot: I haz the power, 2016-06-19 02:29:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-19 02:29:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yuta Kitamura, 2016-06-19 05:21:29]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-19 05:21:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2050123002/90001

[commit-bot: I haz the power, 2016-06-19 06:30:57]

Description was changed from

==========
Remove OwnPtr from Blink.

This huge patch basically consists of the following changes:
  (1) OwnPtr/PassOwnPtr getting renamed to std::unique_ptr;
  (2) adoptPtr getting renamed to wrapUnique;
  (3) adjustments in #include files; and
  (4) occasional addition of .get() calls due to missing operator==()
      comparison of std::unique_ptr<T> and T*.

BUG=582354
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove OwnPtr from Blink.

This huge patch basically consists of the following changes:
  (1) OwnPtr/PassOwnPtr getting renamed to std::unique_ptr;
  (2) adoptPtr getting renamed to wrapUnique;
  (3) adjustments in #include files; and
  (4) occasional addition of .get() calls due to missing operator==()
      comparison of std::unique_ptr<T> and T*.

BUG=582354
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
R=haraken@chromium.org, tkent@chromium.org, tzik@chromium.org

Committed: https://crrev.com/f5f08765522594f41a1c032754e4fbc30e90c134
Cr-Commit-Position: refs/heads/master@{#400613}
==========

[commit-bot: I haz the power, 2016-06-19 06:31:05]

Patchset 11 (id:??) landed as
https://crrev.com/f5f08765522594f41a1c032754e4fbc30e90c134
Cr-Commit-Position: refs/heads/master@{#400613}

[Yuta Kitamura, 2016-06-19 06:31:57]

Description was changed from

==========
Remove OwnPtr from Blink.

This huge patch basically consists of the following changes:
  (1) OwnPtr/PassOwnPtr getting renamed to std::unique_ptr;
  (2) adoptPtr getting renamed to wrapUnique;
  (3) adjustments in #include files; and
  (4) occasional addition of .get() calls due to missing operator==()
      comparison of std::unique_ptr<T> and T*.

BUG=582354
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
R=haraken@chromium.org, tkent@chromium.org, tzik@chromium.org

Committed: https://crrev.com/f5f08765522594f41a1c032754e4fbc30e90c134
Cr-Commit-Position: refs/heads/master@{#400613}
==========

to

==========
Remove OwnPtr from Blink.

This huge patch basically consists of the following changes:
  (1) OwnPtr/PassOwnPtr getting renamed to std::unique_ptr;
  (2) adoptPtr getting renamed to wrapUnique;
  (3) adjustments in #include files; and
  (4) occasional addition of .get() calls due to missing operator==()
      comparison of std::unique_ptr<T> and T*.

BUG=582354
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
R=haraken@chromium.org, tkent@chromium.org, tzik@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/f5f08765522594f41a1c032754e4...
==========

[Yuta Kitamura, 2016-06-19 06:32:07]

Committed patchset #11 (id:100001) manually as
f5f08765522594f41a1c032754e4fbc30e90c134 (tree was closed).