Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtil.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: First attempt to land. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/fetch/DataConsumerHandleUtil.h" 5 #include "modules/fetch/DataConsumerHandleUtil.h"
6 6
7 #include "platform/blob/BlobData.h" 7 #include "platform/blob/BlobData.h"
8 #include "public/platform/Platform.h" 8 #include "public/platform/Platform.h"
9 #include "public/platform/WebTaskRunner.h" 9 #include "public/platform/WebTaskRunner.h"
10 #include "public/platform/WebThread.h" 10 #include "public/platform/WebThread.h"
11 #include "public/platform/WebTraceLocation.h" 11 #include "public/platform/WebTraceLocation.h"
12 #include "wtf/Functional.h" 12 #include "wtf/Functional.h"
13 #include "wtf/PtrUtil.h"
14 #include <memory>
13 15
14 namespace blink { 16 namespace blink {
15 17
16 using Result = WebDataConsumerHandle::Result; 18 using Result = WebDataConsumerHandle::Result;
17 19
18 namespace { 20 namespace {
19 21
20 class WaitingHandle final : public WebDataConsumerHandle { 22 class WaitingHandle final : public WebDataConsumerHandle {
21 private: 23 private:
22 class ReaderImpl final : public WebDataConsumerHandle::Reader { 24 class ReaderImpl final : public WebDataConsumerHandle::Reader {
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 }; 66 };
65 67
66 class UnexpectedErrorHandle final : public WebDataConsumerHandle { 68 class UnexpectedErrorHandle final : public WebDataConsumerHandle {
67 private: 69 private:
68 Reader* obtainReaderInternal(Client* client) override { return new Repeating Reader(UnexpectedError, client); } 70 Reader* obtainReaderInternal(Client* client) override { return new Repeating Reader(UnexpectedError, client); }
69 const char* debugName() const override { return "UnexpectedErrorHandle"; } 71 const char* debugName() const override { return "UnexpectedErrorHandle"; }
70 }; 72 };
71 73
72 class WebToFetchDataConsumerHandleAdapter : public FetchDataConsumerHandle { 74 class WebToFetchDataConsumerHandleAdapter : public FetchDataConsumerHandle {
73 public: 75 public:
74 WebToFetchDataConsumerHandleAdapter(PassOwnPtr<WebDataConsumerHandle> handle ) : m_handle(std::move(handle)) { } 76 WebToFetchDataConsumerHandleAdapter(std::unique_ptr<WebDataConsumerHandle> h andle) : m_handle(std::move(handle)) { }
75 private: 77 private:
76 class ReaderImpl final : public FetchDataConsumerHandle::Reader { 78 class ReaderImpl final : public FetchDataConsumerHandle::Reader {
77 public: 79 public:
78 ReaderImpl(PassOwnPtr<WebDataConsumerHandle::Reader> reader) : m_reader( std::move(reader)) { } 80 ReaderImpl(std::unique_ptr<WebDataConsumerHandle::Reader> reader) : m_re ader(std::move(reader)) { }
79 Result read(void* data, size_t size, Flags flags, size_t* readSize) over ride 81 Result read(void* data, size_t size, Flags flags, size_t* readSize) over ride
80 { 82 {
81 return m_reader->read(data, size, flags, readSize); 83 return m_reader->read(data, size, flags, readSize);
82 } 84 }
83 85
84 Result beginRead(const void** buffer, Flags flags, size_t* available) ov erride 86 Result beginRead(const void** buffer, Flags flags, size_t* available) ov erride
85 { 87 {
86 return m_reader->beginRead(buffer, flags, available); 88 return m_reader->beginRead(buffer, flags, available);
87 } 89 }
88 Result endRead(size_t readSize) override 90 Result endRead(size_t readSize) override
89 { 91 {
90 return m_reader->endRead(readSize); 92 return m_reader->endRead(readSize);
91 } 93 }
92 private: 94 private:
93 OwnPtr<WebDataConsumerHandle::Reader> m_reader; 95 std::unique_ptr<WebDataConsumerHandle::Reader> m_reader;
94 }; 96 };
95 97
96 Reader* obtainReaderInternal(Client* client) override { return new ReaderImp l(m_handle->obtainReader(client)); } 98 Reader* obtainReaderInternal(Client* client) override { return new ReaderImp l(m_handle->obtainReader(client)); }
97 99
98 const char* debugName() const override { return m_handle->debugName(); } 100 const char* debugName() const override { return m_handle->debugName(); }
99 101
100 OwnPtr<WebDataConsumerHandle> m_handle; 102 std::unique_ptr<WebDataConsumerHandle> m_handle;
101 }; 103 };
102 104
103 } // namespace 105 } // namespace
104 106
105 PassOwnPtr<WebDataConsumerHandle> createWaitingDataConsumerHandle() 107 std::unique_ptr<WebDataConsumerHandle> createWaitingDataConsumerHandle()
106 { 108 {
107 return adoptPtr(new WaitingHandle); 109 return wrapUnique(new WaitingHandle);
108 } 110 }
109 111
110 PassOwnPtr<WebDataConsumerHandle> createDoneDataConsumerHandle() 112 std::unique_ptr<WebDataConsumerHandle> createDoneDataConsumerHandle()
111 { 113 {
112 return adoptPtr(new DoneHandle); 114 return wrapUnique(new DoneHandle);
113 } 115 }
114 116
115 PassOwnPtr<WebDataConsumerHandle> createUnexpectedErrorDataConsumerHandle() 117 std::unique_ptr<WebDataConsumerHandle> createUnexpectedErrorDataConsumerHandle()
116 { 118 {
117 return adoptPtr(new UnexpectedErrorHandle); 119 return wrapUnique(new UnexpectedErrorHandle);
118 } 120 }
119 121
120 PassOwnPtr<FetchDataConsumerHandle> createFetchDataConsumerHandleFromWebHandle(P assOwnPtr<WebDataConsumerHandle> handle) 122 std::unique_ptr<FetchDataConsumerHandle> createFetchDataConsumerHandleFromWebHan dle(std::unique_ptr<WebDataConsumerHandle> handle)
121 { 123 {
122 return adoptPtr(new WebToFetchDataConsumerHandleAdapter(std::move(handle))); 124 return wrapUnique(new WebToFetchDataConsumerHandleAdapter(std::move(handle)) );
123 } 125 }
124 126
125 NotifyOnReaderCreationHelper::NotifyOnReaderCreationHelper(WebDataConsumerHandle ::Client* client) 127 NotifyOnReaderCreationHelper::NotifyOnReaderCreationHelper(WebDataConsumerHandle ::Client* client)
126 : m_factory(this) 128 : m_factory(this)
127 { 129 {
128 if (!client) 130 if (!client)
129 return; 131 return;
130 // Note we don't need thread safety here because this object is 132 // Note we don't need thread safety here because this object is
131 // bound to the current thread. 133 // bound to the current thread.
132 Platform::current()->currentThread()->getWebTaskRunner()->postTask(BLINK_FRO M_HERE, bind(&NotifyOnReaderCreationHelper::notify, m_factory.createWeakPtr(), c lient)); 134 Platform::current()->currentThread()->getWebTaskRunner()->postTask(BLINK_FRO M_HERE, bind(&NotifyOnReaderCreationHelper::notify, m_factory.createWeakPtr(), c lient));
133 } 135 }
134 136
135 void NotifyOnReaderCreationHelper::notify(WebDataConsumerHandle::Client* client) 137 void NotifyOnReaderCreationHelper::notify(WebDataConsumerHandle::Client* client)
136 { 138 {
137 // |client| dereference is safe here because: 139 // |client| dereference is safe here because:
138 // - |this| is owned by a reader, 140 // - |this| is owned by a reader,
139 // so the reader outlives |this|, and 141 // so the reader outlives |this|, and
140 // - |client| is the client of the reader, so |client| outlives the reader 142 // - |client| is the client of the reader, so |client| outlives the reader
141 // (guaranteed by the user of the reader), 143 // (guaranteed by the user of the reader),
142 // and therefore |client| outlives |this|. 144 // and therefore |client| outlives |this|.
143 client->didGetReadable(); 145 client->didGetReadable();
144 } 146 }
145 147
146 } // namespace blink 148 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698