third_party/WebKit/Source/modules/websockets/WebSocketChannelClient.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/websockets/WebSocketChannelClient.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/websockets/WebSocketChannel.cpp ('k') | third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/websockets/WebSocketChannelClient.h

diff --git a/third_party/WebKit/Source/modules/websockets/WebSocketChannelClient.h b/third_party/WebKit/Source/modules/websockets/WebSocketChannelClient.h

index 3777408a94bf73a68e31f78deee5b19948059344..25f1926db639d1a3ca97a68a5ecaad11b9e3140a 100644

--- a/third_party/WebKit/Source/modules/websockets/WebSocketChannelClient.h

+++ b/third_party/WebKit/Source/modules/websockets/WebSocketChannelClient.h

@@ -34,8 +34,8 @@

#include "modules/ModulesExport.h"

#include "platform/heap/Handle.h"

#include "wtf/Forward.h"

-#include "wtf/PassOwnPtr.h"

#include "wtf/Vector.h"

+#include <memory>

#include <stdint.h>

namespace blink {

@@ -45,7 +45,7 @@ public:

virtual ~WebSocketChannelClient() { }

virtual void didConnect(const String& subprotocol, const String& extensions) { }

virtual void didReceiveTextMessage(const String&) { }

- virtual void didReceiveBinaryMessage(PassOwnPtr<Vector<char>>) { }

+ virtual void didReceiveBinaryMessage(std::unique_ptr<Vector<char>>) { }

virtual void didError() { }

virtual void didConsumeBufferedAmount(uint64_t consumed) { }

virtual void didStartClosingHandshake() { }