third_party/WebKit/Source/platform/blob/BlobDataTest.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/blob/BlobDataTest.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/blob/BlobDataTest.cpp

diff --git a/third_party/WebKit/Source/platform/blob/BlobDataTest.cpp b/third_party/WebKit/Source/platform/blob/BlobDataTest.cpp

index e7bef25ea6b918cee3f4d66d7cf559f88c01bc4c..8ac1d5ac1d858daceb152645540f4fa58a5d89fa 100644

--- a/third_party/WebKit/Source/platform/blob/BlobDataTest.cpp

+++ b/third_party/WebKit/Source/platform/blob/BlobDataTest.cpp

@@ -6,8 +6,8 @@

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

-#include "wtf/OwnPtr.h"

-#include "wtf/PassOwnPtr.h"

+#include "wtf/PtrUtil.h"

+#include <memory>

namespace blink {

@@ -28,7 +28,7 @@ TEST(BlobDataTest, Consolidation)

EXPECT_EQ(0, memcmp(data.m_items[0].data->data(), "abcdefps1ps2", 12));

- OwnPtr<char[]> large_data = adoptArrayPtr(new char[kMaxConsolidatedItemSizeInBytes]);

+ std::unique_ptr<char[]> large_data = wrapArrayUnique(new char[kMaxConsolidatedItemSizeInBytes]);

data.appendBytes(large_data.get(), kMaxConsolidatedItemSizeInBytes);

EXPECT_EQ(2u, data.m_items.size());