third_party/WebKit/Source/modules/mediastream/RTCDataChannelTest.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCDataChannelTest.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp ('k') | third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/RTCDataChannelTest.cpp

diff --git a/third_party/WebKit/Source/modules/mediastream/RTCDataChannelTest.cpp b/third_party/WebKit/Source/modules/mediastream/RTCDataChannelTest.cpp

index 500a4c2d93d395e0c7deebea363cbd38ae861372..de660958b53d8b14d169ba175828ccdebd0a7d77 100644

--- a/third_party/WebKit/Source/modules/mediastream/RTCDataChannelTest.cpp

+++ b/third_party/WebKit/Source/modules/mediastream/RTCDataChannelTest.cpp

@@ -12,6 +12,7 @@

#include "public/platform/WebRTCDataChannelHandler.h"

#include "public/platform/WebVector.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include "wtf/PtrUtil.h"

#include "wtf/RefPtr.h"

#include "wtf/text/WTFString.h"

@@ -77,7 +78,7 @@ private:

TEST(RTCDataChannelTest, BufferedAmount)

{

MockHandler* handler = new MockHandler();

- RTCDataChannel* channel = RTCDataChannel::create(0, adoptPtr(handler));

+ RTCDataChannel* channel = RTCDataChannel::create(0, wrapUnique(handler));

handler->changeState(WebRTCDataChannelHandlerClient::ReadyStateOpen);

String message(std::string(100, 'A').c_str());

@@ -88,7 +89,7 @@ TEST(RTCDataChannelTest, BufferedAmount)

TEST(RTCDataChannelTest, BufferedAmountLow)

{

MockHandler* handler = new MockHandler();

- RTCDataChannel* channel = RTCDataChannel::create(0, adoptPtr(handler));

+ RTCDataChannel* channel = RTCDataChannel::create(0, wrapUnique(handler));

// Add and drain 100 bytes

handler->changeState(WebRTCDataChannelHandlerClient::ReadyStateOpen);