Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/ConvolverNodeTest.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: First attempt to land. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/testing/DummyPageHolder.h"
5 #include "modules/webaudio/ConvolverNode.h" 6 #include "modules/webaudio/ConvolverNode.h"
6 #include "core/testing/DummyPageHolder.h"
7 #include "modules/webaudio/OfflineAudioContext.h" 7 #include "modules/webaudio/OfflineAudioContext.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 #include <memory>
9 10
10 namespace blink { 11 namespace blink {
11 12
12 TEST(ConvolverNodeTest, ReverbLifetime) 13 TEST(ConvolverNodeTest, ReverbLifetime)
13 { 14 {
14 OwnPtr<DummyPageHolder> page = DummyPageHolder::create(); 15 std::unique_ptr<DummyPageHolder> page = DummyPageHolder::create();
15 OfflineAudioContext* context = OfflineAudioContext::create(&page->document() , 2, 1, 48000, ASSERT_NO_EXCEPTION); 16 OfflineAudioContext* context = OfflineAudioContext::create(&page->document() , 2, 1, 48000, ASSERT_NO_EXCEPTION);
16 ConvolverNode* node = context->createConvolver(ASSERT_NO_EXCEPTION); 17 ConvolverNode* node = context->createConvolver(ASSERT_NO_EXCEPTION);
17 ConvolverHandler& handler = node->convolverHandler(); 18 ConvolverHandler& handler = node->convolverHandler();
18 EXPECT_FALSE(handler.m_reverb); 19 EXPECT_FALSE(handler.m_reverb);
19 node->setBuffer(AudioBuffer::create(2, 1, 48000), ASSERT_NO_EXCEPTION); 20 node->setBuffer(AudioBuffer::create(2, 1, 48000), ASSERT_NO_EXCEPTION);
20 EXPECT_TRUE(handler.m_reverb); 21 EXPECT_TRUE(handler.m_reverb);
21 AbstractAudioContext::AutoLocker locker(context); 22 AbstractAudioContext::AutoLocker locker(context);
22 handler.dispose(); 23 handler.dispose();
23 // m_reverb should live after dispose() because an audio thread is using it. 24 // m_reverb should live after dispose() because an audio thread is using it.
24 EXPECT_TRUE(handler.m_reverb); 25 EXPECT_TRUE(handler.m_reverb);
25 } 26 }
26 27
27 } // namespace blink 28 } // namespace blink
28 29
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698