third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp

index c4157b0382229b02758eed4fcb9e22d44ab2dccd..7c1d7d87db0acc1970b2afb9619aaebf2f87b109 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp

@@ -44,6 +44,7 @@

#include "modules/indexeddb/IDBValue.h"

#include "platform/SharedBuffer.h"

#include "public/platform/WebBlobInfo.h"

+#include <memory>

using blink::WebIDBCursor;

@@ -249,7 +250,7 @@ void IDBRequest::onSuccess(const Vector<String>& stringList)

onSuccessInternal(IDBAny::create(domStringList));

}

-void IDBRequest::onSuccess(PassOwnPtr<WebIDBCursor> backend, IDBKey* key, IDBKey* primaryKey, PassRefPtr<IDBValue> value)

+void IDBRequest::onSuccess(std::unique_ptr<WebIDBCursor> backend, IDBKey* key, IDBKey* primaryKey, PassRefPtr<IDBValue> value)

{

IDB_TRACE("IDBRequest::onSuccess(IDBCursor)");

if (!shouldEnqueueEvent())