third_party/WebKit/Source/web/ExternalPopupMenu.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ExternalPopupMenu.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ExternalPopupMenu.h

diff --git a/third_party/WebKit/Source/web/ExternalPopupMenu.h b/third_party/WebKit/Source/web/ExternalPopupMenu.h

index e11ef4b9308408c2ccbf2afd523505d3739eb0ec..497343c2eb26383c7c66604a21af42bfcdfdae55 100644

--- a/third_party/WebKit/Source/web/ExternalPopupMenu.h

+++ b/third_party/WebKit/Source/web/ExternalPopupMenu.h

@@ -38,6 +38,7 @@

#include "public/web/WebExternalPopupMenuClient.h"

#include "web/WebExport.h"

#include "wtf/Compiler.h"

+#include <memory>

namespace blink {

@@ -85,7 +86,7 @@ private:

Member<HTMLSelectElement> m_ownerElement;

Member<LocalFrame> m_localFrame;

WebViewImpl& m_webView;

- OwnPtr<WebMouseEvent> m_syntheticEvent;

+ std::unique_ptr<WebMouseEvent> m_syntheticEvent;

Timer<ExternalPopupMenu> m_dispatchEventTimer;

// The actual implementor of the show menu.

WebExternalPopupMenu* m_webExternalPopupMenu;