third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/push_messaging/PushSubscription.h ('k') | third_party/WebKit/Source/modules/push_messaging/PushSubscriptionCallbacks.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

index a83699c12ef19d9c3e653e00e0ebf7f9a5b18676..01363e82148f0618121e10c26bfd006b36ef8efb 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

+++ b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

@@ -13,12 +13,12 @@

#include "public/platform/modules/push_messaging/WebPushProvider.h"

#include "public/platform/modules/push_messaging/WebPushSubscription.h"

#include "wtf/Assertions.h"

-#include "wtf/OwnPtr.h"

#include "wtf/text/Base64.h"

+#include <memory>

namespace blink {

-PushSubscription* PushSubscription::take(ScriptPromiseResolver*, PassOwnPtr<WebPushSubscription> pushSubscription, ServiceWorkerRegistration* serviceWorkerRegistration)

+PushSubscription* PushSubscription::take(ScriptPromiseResolver*, std::unique_ptr<WebPushSubscription> pushSubscription, ServiceWorkerRegistration* serviceWorkerRegistration)

{

if (!pushSubscription)

return nullptr;