third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.h

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.h b/third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.h

index 8347cb643b8b1f23b27baf8a4b698383fdcc8a51..637d1a2880d5941284726a703fd5b32a36ea7436 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.h

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.h

@@ -29,6 +29,7 @@

#include "modules/ModulesExport.h"

#include "modules/indexeddb/IDBRequest.h"

#include "public/platform/modules/indexeddb/WebIDBDatabase.h"

+#include <memory>

namespace blink {

@@ -44,8 +45,8 @@ public:

using IDBRequest::onSuccess;

void onBlocked(int64_t existingVersion) override;

- void onUpgradeNeeded(int64_t oldVersion, PassOwnPtr<WebIDBDatabase>, const IDBDatabaseMetadata&, WebIDBDataLoss, String dataLossMessage) override;

- void onSuccess(PassOwnPtr<WebIDBDatabase>, const IDBDatabaseMetadata&) override;

+ void onUpgradeNeeded(int64_t oldVersion, std::unique_ptr<WebIDBDatabase>, const IDBDatabaseMetadata&, WebIDBDataLoss, String dataLossMessage) override;

+ void onSuccess(std::unique_ptr<WebIDBDatabase>, const IDBDatabaseMetadata&) override;

void onSuccess(int64_t oldVersion) override;

// EventTarget