third_party/WebKit/Source/platform/animation/AnimationTranslationUtilTest.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/animation/AnimationTranslationUtilTest.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/WebThreadSupportingGC.cpp ('k') | third_party/WebKit/Source/platform/animation/CompositorAnimation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/animation/AnimationTranslationUtilTest.cpp

diff --git a/third_party/WebKit/Source/platform/animation/AnimationTranslationUtilTest.cpp b/third_party/WebKit/Source/platform/animation/AnimationTranslationUtilTest.cpp

index 0e9ac9b287018da94e767f990b48c8cb347474d3..4a1934bfdd6b94791c7251862ec1845adc963139 100644

--- a/third_party/WebKit/Source/platform/animation/AnimationTranslationUtilTest.cpp

+++ b/third_party/WebKit/Source/platform/animation/AnimationTranslationUtilTest.cpp

@@ -34,13 +34,14 @@

#include "platform/transforms/TranslateTransformOperation.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "wtf/RefPtr.h"

+#include <memory>

namespace blink {

TEST(AnimationTranslationUtilTest, transformsWork)

{

TransformOperations ops;

- OwnPtr<CompositorTransformOperations> outOps = CompositorTransformOperations::create();

+ std::unique_ptr<CompositorTransformOperations> outOps = CompositorTransformOperations::create();

ops.operations().append(TranslateTransformOperation::create(Length(2, Fixed), Length(0, Fixed), TransformOperation::TranslateX));

ops.operations().append(RotateTransformOperation::create(0.1, 0.2, 0.3, 200000.4, TransformOperation::Rotate3D));

@@ -73,7 +74,7 @@ TEST(AnimationTranslationUtilTest, transformsWork)

TEST(AnimationTranslationUtilTest, filtersWork)

{

FilterOperations ops;

- OwnPtr<CompositorFilterOperations> outOps = CompositorFilterOperations::create();

+ std::unique_ptr<CompositorFilterOperations> outOps = CompositorFilterOperations::create();

ops.operations().append(BasicColorMatrixFilterOperation::create(0.5, FilterOperation::SATURATE));

ops.operations().append(BasicColorMatrixFilterOperation::create(0.2, FilterOperation::GRAYSCALE));