third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h ('k') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

index b3cfe304efd812086247ac866261cfbf2a3b1291..2983d672cfa5ba623a798caa1ea4acdc733814be 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

@@ -34,7 +34,7 @@

#include "public/platform/WebURL.h"

#include "public/platform/modules/serviceworker/WebServiceWorkerResponse.h"

#include "public/web/modules/serviceworker/WebServiceWorkerContextClient.h"

-#include "wtf/PassOwnPtr.h"

+#include <memory>

namespace blink {

@@ -122,14 +122,14 @@ void ServiceWorkerGlobalScopeClientImpl::didHandleSyncEvent(int syncEventID, Web

m_client.didHandleSyncEvent(syncEventID, result);

}

-void ServiceWorkerGlobalScopeClientImpl::postMessageToClient(const WebString& clientUUID, const WebString& message, PassOwnPtr<WebMessagePortChannelArray> webChannels)

+void ServiceWorkerGlobalScopeClientImpl::postMessageToClient(const WebString& clientUUID, const WebString& message, std::unique_ptr<WebMessagePortChannelArray> webChannels)

{

- m_client.postMessageToClient(clientUUID, message, webChannels.leakPtr());

+ m_client.postMessageToClient(clientUUID, message, webChannels.release());

}

-void ServiceWorkerGlobalScopeClientImpl::postMessageToCrossOriginClient(const WebCrossOriginServiceWorkerClient& client, const WebString& message, PassOwnPtr<WebMessagePortChannelArray> webChannels)

+void ServiceWorkerGlobalScopeClientImpl::postMessageToCrossOriginClient(const WebCrossOriginServiceWorkerClient& client, const WebString& message, std::unique_ptr<WebMessagePortChannelArray> webChannels)

{

- m_client.postMessageToCrossOriginClient(client, message, webChannels.leakPtr());

+ m_client.postMessageToCrossOriginClient(client, message, webChannels.release());

}

void ServiceWorkerGlobalScopeClientImpl::skipWaiting(WebServiceWorkerSkipWaitingCallbacks* callbacks)