third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp b/third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp

index a5bc137595c1e3f78e07025518cee7cf044c07f0..bb5c6671da72427e954a1a2ba70c8bc294bc2805 100644

--- a/third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp

@@ -10,6 +10,7 @@

#include "core/html/HTMLHtmlElement.h"

#include "core/testing/DummyPageHolder.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include <memory>

namespace blink {

@@ -36,7 +37,7 @@ TEST(HTMLInputElementTest, NoAssertWhenMovedInNewDocument)

toHTMLBodyElement(html->firstChild())->setInnerHTML("<input type='range' />", ASSERT_NO_EXCEPTION);

documentWithoutFrame->appendChild(html);

- OwnPtr<DummyPageHolder> pageHolder = DummyPageHolder::create();

+ std::unique_ptr<DummyPageHolder> pageHolder = DummyPageHolder::create();

auto& document = pageHolder->document();

EXPECT_NE(nullptr, document.frameHost());