third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

diff --git a/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp b/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

index b4bd8b077af638d0bda714ac5f59c67ef751675e..a48b89b2e02bac5222ce08bc5ea228367f3f11d7 100644

--- a/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

+++ b/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

@@ -23,6 +23,7 @@

#include "testing/gtest/include/gtest/gtest.h"

#include "web/WebLocalFrameImpl.h"

#include "web/tests/FrameTestHelpers.h"

+#include <memory>

namespace blink {

@@ -42,7 +43,7 @@ protected:

m_dummyPageHolder->document().updateStyleAndLayoutIgnorePendingStylesheets();

}

- OwnPtr<DummyPageHolder> m_dummyPageHolder;

+ std::unique_ptr<DummyPageHolder> m_dummyPageHolder;

Persistent<HTMLSelectElement> m_ownerElement;

};