third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp ('k') | third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

diff --git a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

index b671c5c95cb8186baf788115e7f360962b8b0fcc..9f93a00e0f9e9bbac25c18e8f2fa92bee2b15961 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

+++ b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

@@ -27,6 +27,8 @@

#include "public/platform/WebCredentialManagerError.h"

#include "public/platform/WebFederatedCredential.h"

#include "public/platform/WebPasswordCredential.h"

+#include "wtf/PtrUtil.h"

+#include <memory>

namespace blink {

@@ -80,7 +82,7 @@ public:

Frame* frame = toDocument(m_resolver->getScriptState()->getExecutionContext())->frame();

SECURITY_CHECK(!frame || frame == frame->tree().top());

- OwnPtr<WebCredential> credential = adoptPtr(webCredential.release());

+ std::unique_ptr<WebCredential> credential = wrapUnique(webCredential.release());

if (!credential || !frame) {

m_resolver->resolve();

return;