third_party/WebKit/Source/modules/indexeddb/IDBRequest.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBRequest.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/indexeddb/IDBRequest.h

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBRequest.h b/third_party/WebKit/Source/modules/indexeddb/IDBRequest.h

index 16e1875f04559dd111a0b274308fb0ce7369cd4f..112f0b05b1aca5bd3e614fe060397aedf708e349 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBRequest.h

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBRequest.h

@@ -46,6 +46,7 @@

#include "public/platform/WebBlobInfo.h"

#include "public/platform/modules/indexeddb/WebIDBCursor.h"

#include "public/platform/modules/indexeddb/WebIDBTypes.h"

+#include <memory>

namespace blink {

@@ -97,7 +98,7 @@ public:

virtual void onError(DOMException*);

virtual void onSuccess(const Vector<String>&);

- virtual void onSuccess(PassOwnPtr<WebIDBCursor>, IDBKey*, IDBKey* primaryKey, PassRefPtr<IDBValue>);

+ virtual void onSuccess(std::unique_ptr<WebIDBCursor>, IDBKey*, IDBKey* primaryKey, PassRefPtr<IDBValue>);

virtual void onSuccess(IDBKey*);

virtual void onSuccess(PassRefPtr<IDBValue>);

virtual void onSuccess(const Vector<RefPtr<IDBValue>>&);

@@ -107,8 +108,8 @@ public:

// Only IDBOpenDBRequest instances should receive these:

virtual void onBlocked(int64_t oldVersion) { ASSERT_NOT_REACHED(); }

- virtual void onUpgradeNeeded(int64_t oldVersion, PassOwnPtr<WebIDBDatabase>, const IDBDatabaseMetadata&, WebIDBDataLoss, String dataLossMessage) { ASSERT_NOT_REACHED(); }

- virtual void onSuccess(PassOwnPtr<WebIDBDatabase>, const IDBDatabaseMetadata&) { ASSERT_NOT_REACHED(); }

+ virtual void onUpgradeNeeded(int64_t oldVersion, std::unique_ptr<WebIDBDatabase>, const IDBDatabaseMetadata&, WebIDBDataLoss, String dataLossMessage) { ASSERT_NOT_REACHED(); }

+ virtual void onSuccess(std::unique_ptr<WebIDBDatabase>, const IDBDatabaseMetadata&) { ASSERT_NOT_REACHED(); }

// ActiveScriptWrappable

bool hasPendingActivity() const final;