third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/FetchDataLoaderTest.cpp ('k') | third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.h

diff --git a/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.h b/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.h

index ab25ff88bd32c094ca1a00a158067270e7275622..2abe693d2e8192e3f3bcbc098e3db6b51ae190fb 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.h

+++ b/third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.h

@@ -13,10 +13,10 @@

#include "platform/blob/BlobData.h"

#include "platform/network/EncodedFormData.h"

#include "wtf/Forward.h"

-#include "wtf/PassOwnPtr.h"

#include "wtf/PassRefPtr.h"

#include "wtf/RefPtr.h"

#include "wtf/ThreadSafeRefCounted.h"

+#include <memory>

namespace blink {

@@ -27,16 +27,16 @@ class ExecutionContext;

class MODULES_EXPORT FetchFormDataConsumerHandle final : public FetchDataConsumerHandle {

WTF_MAKE_NONCOPYABLE(FetchFormDataConsumerHandle);

public:

- static PassOwnPtr<FetchDataConsumerHandle> create(const String& body);

- static PassOwnPtr<FetchDataConsumerHandle> create(DOMArrayBuffer* body);

- static PassOwnPtr<FetchDataConsumerHandle> create(DOMArrayBufferView* body);

- static PassOwnPtr<FetchDataConsumerHandle> create(const void* data, size_t);

- static PassOwnPtr<FetchDataConsumerHandle> create(ExecutionContext*, PassRefPtr<EncodedFormData> body);

+ static std::unique_ptr<FetchDataConsumerHandle> create(const String& body);

+ static std::unique_ptr<FetchDataConsumerHandle> create(DOMArrayBuffer* body);

+ static std::unique_ptr<FetchDataConsumerHandle> create(DOMArrayBufferView* body);

+ static std::unique_ptr<FetchDataConsumerHandle> create(const void* data, size_t);

+ static std::unique_ptr<FetchDataConsumerHandle> create(ExecutionContext*, PassRefPtr<EncodedFormData> body);

// Use FetchBlobDataConsumerHandle for blobs.

~FetchFormDataConsumerHandle() override;

- static PassOwnPtr<FetchDataConsumerHandle> createForTest(

+ static std::unique_ptr<FetchDataConsumerHandle> createForTest(

ExecutionContext*,

PassRefPtr<EncodedFormData> body,

FetchBlobDataConsumerHandle::LoaderFactory*);